Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish #43876

Closed
wants to merge 4 commits into from
Closed

Polish #43876

wants to merge 4 commits into from

Conversation

arefbehboudi
Copy link
Contributor

  • Variables that were instantiated only once were made final.
  • Methods whose return values were not used were changed to void.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 18, 2025
mhalbritter
mhalbritter reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@mhalbritter mhalbritter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've added some comments.

@mhalbritter mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Jan 20, 2025
@arefbehboudi
Copy link
Contributor Author

@mhalbritter Thank you for your feedback.
I have updated the pull request.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jan 20, 2025
@mhalbritter mhalbritter added type: task A general task and removed status: feedback-provided Feedback has been provided status: waiting-for-triage An issue we've not yet triaged labels Jan 20, 2025
@mhalbritter mhalbritter added this to the 3.5.x milestone Jan 20, 2025
@wilkinsona wilkinsona modified the milestones: 3.5.x, 3.3.x Jan 21, 2025
@arefbehboudi
Polish
e5aeca0 
Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
@arefbehboudi
Resolve comments
2cc57bc 
Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
@arefbehboudi
Resolve comments
6b19b48 
Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
@arefbehboudi
Resolve comments
ba5704e 
Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
@wilkinsona wilkinsona self-assigned this Jan 21, 2025
@wilkinsona wilkinsona mentioned this pull request Jan 21, 2025
Closed
@wilkinsona wilkinsona modified the milestones: 3.3.x, 3.3.8 Jan 21, 2025
wilkinsona pushed a commit that referenced this pull request Jan 21, 2025
@arefbehboudi @wilkinsona
Polish
c6b6d0c 
See gh-43876

Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
@wilkinsona
Copy link
Member

Thank you, @arefbehboudi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona wilkinsona approved these changes

@mhalbritter mhalbritter Awaiting requested review from mhalbritter

Assignees

@wilkinsona wilkinsona

Labels
type: task A general task
Projects
None yet
Milestone
3.3.8
Development

Successfully merging this pull request may close these issues.
4 participants
@arefbehboudi @wilkinsona @mhalbritter @spring-projects-issues