Polish PropertiesRedisConnectionDetails #43825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
quaff
commented
Jan 15, 2025
| return Standalone.of(connectionInfo.getUri().getHost(), connectionInfo.getUri().getPort(), | ||
| this.properties.getDatabase()); | ||
| } | ||
| return Standalone.of(this.properties.getHost(), this.properties.getPort(), this.properties.getDatabase()); | ||
| } | ||
|
|
||
| private ConnectionInfo connectionInfo(String url) { | ||
| return (url != null) ? RedisConnectionConfiguration.parseUrl(url) : null; |
There was a problem hiding this comment.
url is never null here.
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: task
wilkinsona
pushed a commit
that referenced
this pull request
Jan 15, 2025
See gh-43825 Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
wilkinsona
added a commit
that referenced
this pull request
Jan 15, 2025
|
Thanks, @quaff. Your changes inspired me to go a bit further and polish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.