Docker Compose support for ClickHouse does not allow an empty password when ALLOW_EMPTY_PASSWORD=yes

[hezean]

Adds yes as a positive value for ALLOW_EMPTY_PASSWORD in bitnami/clickhouse.

[hezean]

Actually I'm wondering if simply using continsKey would make the code more consistent with others like bitnami/mysql and bitnami/mariadb.

I'd prefer that we just consistently look for ALLOW_EMPTY_PASSWORD being set to any value and allow Bitnami to do the actual checking. That isolates Boot from any changes to what Bitnami supports and/or documents in the future. This isolation is important as Boot doesn't control the version of any Bitnami container that's used so we don't control when a user may try to use a container with different rules for the value of ALLOW_EMPTY_PASSWORD.

Originally posted by @wilkinsona in #43771 (comment)

But for the below existing test, we can either: delete it, or add a check to prevent breaking changes, like

boolean allowEmpty = env.containsKey("ALLOW_EMPTY_PASSWORD") && !"false".equalsIgnoreCase(env.get("ALLOW_EMPTY_PASSWORD"))

spring-boot/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/clickhouse/ClickHouseEnvironmentTests.java

Lines 58 to 63 in 2015fae

	@Test
	void getPasswordWhenHasNoPasswordAndAllowEmptyPasswordIsFalse() {
	assertThatIllegalStateException()
	.isThrownBy(() -> new ClickHouseEnvironment(Map.of("ALLOW_EMPTY_PASSWORD", "false")))
	.withMessage("No ClickHouse password found");
	}

[wilkinsona]

Actually I'm wondering if simply using continsKey would make the code more consistent with others like bitnami/mysql and bitnami/mariadb.

Yes, please. I think that's what we should do.

But for the below existing test, we can either: delete it, or add a check to prevent breaking changes

I think we should just delete it for consistency with the other tests.

[wilkinsona]

Thanks very much, @hezean.