Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve diagnostics when unable to find a @SpringBootConfiguration #43358

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Dec 3, 2024

Close GH-43357

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 3, 2024
@wilkinsona
Copy link
Member

Thanks for the PR but this change is incorrect. Please see #43357 (comment) for details.

@wilkinsona wilkinsona closed this Dec 3, 2024
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 3, 2024
@quaff
Copy link
Contributor Author

quaff commented Dec 4, 2024

Thanks for the PR but this change is incorrect. Please see #43357 (comment) for details.

It's better to revise the exception message, it's confusing currently.

@philwebb philwebb added the for: team-meeting An issue we'd like to discuss as a team to make progress label Dec 4, 2024
@philwebb
Copy link
Member

philwebb commented Dec 4, 2024

@quaff I've reopened #43357 to consider what we can do

@philwebb philwebb removed the for: team-meeting An issue we'd like to discuss as a team to make progress label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to find a @SpringBootConfiguration results in misleading error message
4 participants