Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply IntelliJ inspections to improve code quality #39259

Closed
wants to merge 19 commits into from
Closed

Apply IntelliJ inspections to improve code quality #39259

wants to merge 19 commits into from

Conversation

tobias-lippert
Copy link
Contributor

I ran IntelliJ inspections on the Spring Boot codebase and found a couple of places worth applying the suggestions.
I've placed each of the different suggestions in a separate commit, so if you disagree with some of them, I can easily revert them.
The commit messages should indicate what's changed.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 21, 2024
@philwebb philwebb self-assigned this Jan 22, 2024
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 22, 2024
@philwebb philwebb added this to the 3.3.x milestone Jan 22, 2024
@philwebb philwebb changed the title Code quality improvements Apply IntelliJ inspections to improve code quality Jan 23, 2024
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Remove unnecessary toString calls
17902c9 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Remove unnecessary semicolons
9cdd0c3 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Inline redundant if statements
def7523 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Simplify conditionals
65a1ff8 
See gh-39259
philwebb added a commit that referenced this pull request Jan 23, 2024
@philwebb
Polish 'Simplify conditionals'
ddb769b 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Use string.repeat()
fe38cb3 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Use pattern variables
06265ee 
See gh-39259
philwebb added a commit that referenced this pull request Jan 23, 2024
@philwebb
Polish 'Use pattern variables'
e40f49d 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Remove redundant boxing
74a7fbe 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Avoid redundant boxing
ac5a08a 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Replace explicit type with diamond operator
cb26c31 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Use try with resources instead of try-finally
316b415 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Replace multiple ifs with switch
0613034 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Remove redundant array creation
d3c97ad 
See gh-39259
philwebb added a commit that referenced this pull request Jan 23, 2024
@philwebb
Polish 'Remove redundant array creation'
15f1e85 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Simplify stream chain operations
7f4aaac 
See gh-39259
philwebb added a commit that referenced this pull request Jan 23, 2024
@philwebb
Polish 'Simplify stream chain operations'
48343cc 
See gh-39259
philwebb pushed a commit that referenced this pull request Jan 23, 2024
@tobias-lippert @philwebb
Replace !Optional.isPresent with Optional.isEmpty
24e0864 
See gh-39259
philwebb added a commit that referenced this pull request Jan 23, 2024
@philwebb
Update copyright header of cleaned up code
8f1a330 
See gh-39259
@philwebb philwebb closed this in 8870834 Jan 23, 2024
@philwebb philwebb modified the milestones: 3.3.x, 3.3.0-M2 Jan 23, 2024
@philwebb
Copy link
Member

Thanks very much @tobias-lippert. I've merged almost all of these except the changes in the JSON code which we copied from another project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@philwebb philwebb

Labels
type: task A general task
Projects
None yet
Milestone
3.3.0-M2
Development

Successfully merging this pull request may close these issues.
3 participants
@tobias-lippert @philwebb @spring-projects-issues