Add service connection support for ActiveMQ #35080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
requested changes
Apr 19, 2023
There was a problem hiding this comment.
Thanks very much for the PR, @eddumelendez. You're quite prolific! I've left a few comments for your consideration when you have time.
...va/org/springframework/boot/autoconfigure/jms/activemq/ActiveMQConnectionFactoryFactory.java
Show resolved
Hide resolved
...org/springframework/boot/autoconfigure/jms/activemq/PropertiesActiveMQConnectionDetails.java
Outdated
Show resolved
Hide resolved
...java/org/springframework/boot/autoconfigure/jms/activemq/ConnectionDetailsConfiguration.java
Outdated
Show resolved
Hide resolved
...java/org/springframework/boot/autoconfigure/jms/activemq/ConnectionDetailsConfiguration.java
Outdated
Show resolved
Hide resolved
|
I've updated the PR addressing your comment. Thanks for the quick review, @wilkinsona ! |
eddumelendez
commented
Apr 19, 2023
| extends ContainerConnectionDetailsFactory<ActiveMQConnectionDetails, Container<?>> { | ||
|
|
||
| ActiveMQContainerConnectionDetailsFactory() { | ||
| super("symptoma/activemq"); |
There was a problem hiding this comment.
I've updated this from activemq to symptoma/activemq because it's similar to the Testcontainers mechanism to make sure this works with this image or a similar one to this. The image besides running on arm too it provides good mechanism to set username and password
wilkinsona
added
type: enhancement
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Jul 20, 2023
snicoll
added a commit
that referenced
this pull request
Jul 20, 2023
This also adds support for Docker Compose. See gh-35080
|
Thanks very much Eddú. I've polished the contribution to add support for Docker Compose as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.