-
Notifications
You must be signed in to change notification settings - Fork 41.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kotlin Symbol Processor for auto configuration #28668
Conversation
@bespaltovyj Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Thanks for opening this, @bespaltovyj. I haven't yet looked closely at what will be required to support KSP, but I had imagined that we would refactor the existing logic so that it can be called from either a Kotlin symbol processor or a Java annotation processor. Compared to duplicating the logic, this should make it easier to achieve consistent behaviour across the two processors particularly in the case of the |
Ok, I'll try to combine KSP and annotation processing in Java. |
1ca278f
to
902dd0b
Compare
b60b092
to
5e7ef06
Compare
@bespaltovyj thanks for working on this. Do you know if there is still anything missing here, besides you signing the "Contributor License Agreement"? |
@cd-ff I don't understand what you mean. Can add more details? |
@bespaltovyj I believe @cd-ff was referring to the earlier request to sign the CLA. |
I resign CLA yesterday |
@bespaltovyj Thank you for signing the Contributor License Agreement! |
What would be required to allow this feature to be implemented, are there changes that need to be made or just tests that need to be fixed / need to work? |
5e7ef06
to
fde4660
Compare
Any updates? |
We chatted about this today and I'm afraid that we decided that we don't think this is something that we'll be able to merge. Sorry. We need to take a step back, consider our options for #28046 and decide how we want to tackle KSP support in general. |
KSP issue - #28046
I made a draft in which I added support for ksp.
I have a few questions:
spring-autoconfigure-metadata.properies
file somewhere? The result of processing java annotations is slightly different from the results of ksp and it is unclear whether these differences affect something.If you tell me what fixes are needed now, then after that I will start doing ksp support for
spring-boot-configuration-processor