Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Maven spring-boot:run to launch JVM with flags to enable development-time optimisations #16941

Closed
wants to merge 5 commits into from
Closed

Update Maven spring-boot:run to launch JVM with flags to enable development-time optimisations #16941

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 22, 2019 •
edited by philwebb
Loading

Fix for #16222

@ghost ghost mentioned this pull request May 22, 2019
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 22, 2019
wilkinsona
wilkinsona requested changes May 23, 2019
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I think that the new optimizedLaunch property should be in RunMojo rather than AbstractRunMojo. This will mean that it only affects the run goal which is used during development and does not affect the start goal which is used for integration testing with Failsafe. The additional arguments can then be added in runWithForkedJvm. If you agree, would you like to update your PR accordingly?

@wilkinsona wilkinsona mentioned this pull request May 23, 2019
Closed
@ghost
Copy link
Author

ghost commented May 23, 2019

@wilkinsona Thank you for the feedback. I have updated the PR with suggestions. Please review when you have time and suggest if there is anything I missed or should have done in a better way. Thanks a lot.

@ghost
Copy link
Author

ghost commented May 23, 2019

I see that it's failing because of the format, fixing it, will push in few minutes.

@wilkinsona wilkinsona changed the title Default to optimizedLaunch of the JVM for Maven Update Maven spring-boot:run to launch JVM with flags to enable development-time optimisations May 25, 2019
@wilkinsona wilkinsona self-assigned this May 25, 2019
@wilkinsona wilkinsona added theme: performance Issues related to general performance type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 25, 2019
@wilkinsona wilkinsona added this to the 2.2.x milestone May 25, 2019
@snicoll
Copy link
Member

snicoll commented May 25, 2019

Interesting to see that that -Xverify:none is deprecated in Java 13 https://bugs.openjdk.java.net/browse/JDK-8218003

@snicoll snicoll changed the title Update Maven spring-boot:run to launch JVM with flags to enable development-time optimisations Default to optimized launch of the JVM when using spring-boot:run May 25, 2019
@snicoll snicoll modified the milestones: 2.2.x, 2.2.0.M4 May 25, 2019
snicoll pushed a commit that referenced this pull request May 25, 2019
@snicoll
Default to optimized launch of the JVM when using spring-boot:run
569b850 
See gh-16941
@snicoll snicoll closed this in 4cdb5a8 May 25, 2019
snicoll added a commit that referenced this pull request May 25, 2019
@snicoll
Merge pull request #16941 from dosdebug
15bdc12 
* pr/16941:
  Polish "Default to optimized launch of the JVM when using spring-boot:run"
  Default to optimized launch of the JVM when using spring-boot:run
@snicoll
Copy link
Member

snicoll commented May 25, 2019

@dosdebug thank you for making your first contribution to Spring Boot. This is now merged in master with a polish commit.

@wilkinsona I didn't notice you were assigned until I had everything ready to go, hope there isn't any wasted effort there.

@wilkinsona wilkinsona changed the title Default to optimized launch of the JVM when using spring-boot:run Update Maven spring-boot:run to launch JVM with flags to enable development-time optimisations May 25, 2019
@wilkinsona
Copy link
Member

No problem, @snicoll. I hadn't started work on merging it. I've just reverted the issue's title back to the one is used earlier which aligns it with the corresponding issue for Gradle.

@snicoll snicoll assigned snicoll and wilkinsona and unassigned wilkinsona May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

@wilkinsona wilkinsona

Labels
theme: performance Issues related to general performance type: enhancement A general enhancement
Projects
None yet
Milestone
2.2.0.M4
Development

Successfully merging this pull request may close these issues.
3 participants
@snicoll @wilkinsona @spring-projects-issues