Skip to content

Add .gitignore for Gradle Plugin module #13137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented May 10, 2018

If one attempts to compile Spring Boot project in IntelliJ, there are errors in spring-boot-gradle-plugin module unless that module is imported as Gradle project. Doing so (by default) generates out/ directory with compilation output and these files are not ignored by Git ATM.

This PR updates .gitignore to add out/ pattern adds .gitignore for Gradle Plugin module.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 10, 2018
Copy link
Member

@snicoll snicoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I am not sure about that pattern and I'd like @wilkinsona to have a look to it first.

.gitignore Outdated
@@ -38,3 +38,4 @@ transaction-logs
secrets.yml
.gradletasknamecache
.sts4-cache
out/
Copy link
Member

@snicoll snicoll May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not super keen to add such a global pattern. Perhaps we should make that a bit more specific? See also spring-io/initializr#657

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one's a quite common .gitignore entry for IntelliJ. For instance, see GitHub's own Jetbrains .gitignore template. That being said, I'm fine with it being updated to something more specific if you prefer.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label May 11, 2018
@wilkinsona
Copy link
Member

I agree on making this more specific. In fact, I'd do the same for bin too. It's Eclipse's equivalent of out and also only applies to the Gradle plugin. While we're at it, we could do something for build too.

There's more than one way to make the ignore more specific, but I think I'd create a separate .gitignore file in the Gradle plugin's directory. That'd mean the new file had the following contents:

/bin/
/build/
/out/

@vpavic vpavic force-pushed the update-gitignore branch from c77cbb3 to 194081b Compare May 11, 2018 09:50
@vpavic vpavic changed the title Update .gitignore Add .gitignore for Gradle Plugin module May 11, 2018
@vpavic
Copy link
Contributor Author

vpavic commented May 11, 2018

Thanks for the feedback - I've updated the PR according to separate .gitignore file suggestion.

@snicoll snicoll added type: task A general task and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels May 11, 2018
@snicoll snicoll self-assigned this May 11, 2018
@snicoll snicoll added this to the 2.0.3 milestone May 11, 2018
snicoll added a commit that referenced this pull request May 11, 2018
* pr/13137:
  Add .gitignore for Gradle Plugin module
@snicoll snicoll closed this in a08fa27 May 11, 2018
@vpavic vpavic deleted the update-gitignore branch May 11, 2018 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants