-
Notifications
You must be signed in to change notification settings - Fork 41.1k
Add .gitignore for Gradle Plugin module #13137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I am not sure about that pattern and I'd like @wilkinsona to have a look to it first.
.gitignore
Outdated
@@ -38,3 +38,4 @@ transaction-logs | |||
secrets.yml | |||
.gradletasknamecache | |||
.sts4-cache | |||
out/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not super keen to add such a global pattern. Perhaps we should make that a bit more specific? See also spring-io/initializr#657
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That one's a quite common .gitignore
entry for IntelliJ. For instance, see GitHub's own Jetbrains .gitignore
template. That being said, I'm fine with it being updated to something more specific if you prefer.
I agree on making this more specific. In fact, I'd do the same for There's more than one way to make the ignore more specific, but I think I'd create a separate
|
Thanks for the feedback - I've updated the PR according to separate |
* pr/13137: Add .gitignore for Gradle Plugin module
If one attempts to compile Spring Boot project in IntelliJ, there are errors in
spring-boot-gradle-plugin
module unless that module is imported as Gradle project. Doing so (by default) generatesout/
directory with compilation output and these files are not ignored by Git ATM.This PR
updatesadds .gitignore for Gradle Plugin module..gitignore
to addout/
pattern