Remove explicit type arguments #10494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @izeye. Out of interest, how did you find these? It'd be nice to rely on inference where possible in 1.5.x as well and cherry picking this back might not be straightforward. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@wilkinsona I just filtered them using |
|
The equivalent changes don't work well on 1.5.x, I think due to different type inferencing in javac when it's targeting 1.6-compatible byte code. Let's just make these changes in master. |
wilkinsona
added
type: task
wilkinsona
pushed a commit
that referenced
this pull request
Oct 24, 2017
wilkinsona
added a commit
that referenced
this pull request
Oct 24, 2017
* gh-10494: Polish “Remove explicit type arguments” Remove explicit type arguments
|
Thanks once again, @izeye. This change is now in master. Just FYI, I dropped the changes to the JOOQ-generated source as they'll get clobbered the next time the source is regenerated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes explicit type arguments which can be inferred.