Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing attributes to FilterRegistration annotation #45005

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

kwondh5217
Copy link

Closes gh-45000

Signed-off-by: Daeho Kwon <trewq231@naver.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 4, 2025
@mhalbritter mhalbritter added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 7, 2025
@mhalbritter mhalbritter added this to the 3.5.x milestone Apr 7, 2025
@mhalbritter mhalbritter changed the title Add initParameters and servletRegistrationBeans to @FilterRegistration Add missing attributes to FilterRegistration annotation Apr 7, 2025
Signed-off-by: Daeho Kwon <trewq231@naver.com>
@kwondh5217 kwondh5217 requested review from nosan and mhalbritter April 7, 2025 12:12
Signed-off-by: Daeho Kwon <trewq231@naver.com>
@kwondh5217 kwondh5217 requested a review from nosan April 7, 2025 12:40
Copy link
Contributor

@nosan nosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks, @kwondh5217

Signed-off-by: Daeho Kwon <trewq231@naver.com>
Signed-off-by: Daeho Kwon <trewq231@naver.com>
Signed-off-by: Daeho Kwon <trewq231@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing attributes to FilterRegistration annotation
4 participants