Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document 'base64:' prefix support #43809

Closed
philwebb opened this issue Jan 13, 2025 · 3 comments
Closed

Document 'base64:' prefix support #43809

philwebb opened this issue Jan 13, 2025 · 3 comments
Assignees
@snicoll
Labels
type: documentation A documentation update
Milestone
3.3.8

Comments

@philwebb
Copy link
Member

As noted in #41047 (comment), we are currently missing documentation for base64: prefix support.
@philwebb philwebb added the type: documentation A documentation update label Jan 13, 2025
@philwebb philwebb added this to the 3.3.x milestone Jan 13, 2025
@philwebb philwebb mentioned this issue Jan 13, 2025
Closed
@snicoll snicoll self-assigned this Jan 15, 2025
@snicoll snicoll modified the milestones: 3.3.x, 3.3.8 Jan 15, 2025
@snicoll snicoll mentioned this issue Jan 15, 2025
Closed
@vpavic
Copy link
Contributor

vpavic commented Jan 15, 2025

I think the documentation committed to close this is not valid for 3.3 as support for arbitrary base64-encoded Resource properties has only been added in 3.4 - see #41433.

@philwebb philwebb reopened this Jan 15, 2025
@snicoll
Copy link
Member

snicoll commented Jan 16, 2025

Oh, that's very confusing then knowing that the code is available in 3.3.x and registered in META-INF/spring.factories.

snicoll added a commit that referenced this issue Jan 16, 2025
@snicoll
Polish "Document 'base64:' prefix support"
89ffe1a 
Resolution of base64 encoded data to arbitrary resources has been
introduced in Spring Boot 3.4. This commit adapts the documentation to
restrict this support to SSL only.

This commit also polishes the phrasing a bit.

See gh-43809
@snicoll
Copy link
Member

snicoll commented Jan 16, 2025

I've adapted the doc for 3.3.x in 89ffe1a

@snicoll snicoll closed this as completed Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: documentation A documentation update
Projects
None yet
Milestone
3.3.8
Development

No branches or pull requests
3 participants
@snicoll @philwebb @vpavic