Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several auto-configurations are creating JMX beans unnecessarily #43706

Closed
philwebb opened this issue Jan 7, 2025 · 1 comment
Closed

Several auto-configurations are creating JMX beans unnecessarily #43706

philwebb opened this issue Jan 7, 2025 · 1 comment
Assignees
@philwebb
Labels
type: bug A general bug
Milestone
3.5.0-M1

Comments

@philwebb
Copy link
Member

philwebb commented Jan 7, 2025

We have a few @ConditionalOnProperty annotations that check for "spring.jmx" with matchIfMissing = true (e.g. org.springframework.boot.autoconfigure.integration.IntegrationAutoConfiguration.IntegrationJmxConfiguration).

Since commit ce9626d JmxAutoConfiguration does not have matchIfMissing, so I wonder if we should align all our conditions.
@philwebb philwebb added type: task A general task status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress and removed type: task A general task labels Jan 7, 2025
@snicoll snicoll changed the title Review @ConditionalOnProperty with spring.jmx Review @ConditionalOnProperty with spring.jmx.enabled Jan 7, 2025
@philwebb philwebb added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress labels Jan 8, 2025
@philwebb philwebb changed the title Review @ConditionalOnProperty with spring.jmx.enabled Several auto-configurations are creating JMX beans unessarily Jan 8, 2025
@philwebb philwebb added this to the 3.5.x milestone Jan 8, 2025
@philwebb
Copy link
Member Author

philwebb commented Jan 8, 2025

This is a bug, but it's been this way since 2019 and there are some risks involved so we'll fix it only in 3.5

@philwebb philwebb self-assigned this Jan 8, 2025
@philwebb philwebb modified the milestones: 3.5.x, 3.5.0-M1 Jan 8, 2025
@wilkinsona wilkinsona changed the title Several auto-configurations are creating JMX beans unessarily Several auto-configurations are creating JMX beans unnecessarily Jan 8, 2025
philwebb added a commit that referenced this issue Jan 8, 2025
@philwebb
Fix tests failing due to missing 'spring.jmx.enabled=true'
52b9b8e 
See gh-43706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: bug A general bug
Projects
None yet
Milestone
3.5.0-M1
Development

No branches or pull requests
1 participant
@philwebb