Failure analysis for InvalidConfigurationPropertyValueException doesn't correctly handle fuzzy matching of environment variables #43380
Comments
wilkinsona
added a commit
that referenced
this issue
Dec 12, 2024
Prior to this change, the failure analysis for an invalid configuration property value filtered out the configuration property sources property source. This property source contains a "duplicate" of all of the environment's other property sources but with configuration property support (such as relaxed/fuzzy matching of environment variables). This was done to prevent the reporting of duplicates when a property was found in both the configuration property sources property source and the "normal" property sources. An unwanted side-effect of this was that fuzzy matching of environment variables was lost so the origin of com.example.some-property would be found in the environment variable was COM_EXAMPLE_SOME_PROPERTY but would not be found if it was COM_EXAMPLE_SOMEPROPERTY. This commit addresses this side-effect by no longer filtering out the configuration property sources property source. To then prevent duplicates from being reported in the analysis, it instead deduplicates things based on the origin of each property that's found in the environment's property sources. Fixes gh-43380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example, the property
management.endpoints.enabled-by-defaultcould be resolved from the environment variableMANAGEMENT_ENDPOINTS_ENABLED_BY_DEFAULTor the environment variableMANAGEMENT_ENDPOINTS_ENABLEDBYDEFAULT. In the former case, the failure analysis reports that the system environment is the origin. In the latter case, it doesn't report the origin as it fails to find the property.This behavior is due to the failure analyzer filtering out the
ConfigurationPropertySourcethat's attached to the environment. The fuzzy matching of environment variables happens withConfigurationPropertySourceso this is lost when it's filtered out. If the filtering is removed, things work forMANAGEMENT_ENDPOINTS_ENABLEDBYDEFAULT. Unfortunately, it creates a different problem withMANAGEMENT_ENDPOINTS_ENABLED_BY_DEFAULTas the property is then found twice – once inConfigurationPropertySource's view of the system environment and once directly from the system environment property source.The text was updated successfully, but these errors were encountered: