Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use paketobuildpacks/builder-noble-java-tiny as the default image builder #42711

Open
ThomasVitale opened this issue Oct 16, 2024 · 12 comments
Open
Assignees
Labels
status: blocked An issue that's blocked on an external project change type: enhancement A general enhancement
Milestone

Comments

@ThomasVitale
Copy link

In #42508, the default Buildpacks builder used by the upcoming Spring Boot 3.4 has been changed to paketobuildpacks/builder-jammy-java-tiny (Ubuntu 22.04). Since the current LTS version of Ubuntu is 24.04, what do you think about using paketobuildpacks/builder-noble-java-tiny (Ubuntu 24.04) as the default instead?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 16, 2024
@wilkinsona
Copy link
Member

WDYT, @anthonydahanne?

@wilkinsona wilkinsona added the status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team label Oct 16, 2024
@philwebb philwebb changed the title Use paketobuildpacks/builder-noble-java-tiny as the default image builder Use paketobuildpacks/builder-noble-java-tiny as the default image builder Oct 21, 2024
@philwebb
Copy link
Member

This has been raised again in #43960. @anthonydahanne, is there any reason we should not to upgrade in Spring Boot 3.5?

@philwebb philwebb marked this as a duplicate of #43960 Jan 24, 2025
@scottfrederick
Copy link
Contributor

See https://paketobuildpacks.slack.com/archives/C0124SD3GTG/p1736791693871209 for a recent Slack discussion about the stability of the Noble-based builders.

@patpatpat123
Copy link

Hello team, hello @scottfrederick , is it possible to join the slack discussion?

@scottfrederick
Copy link
Contributor

@patpatpat123 There is a link here to join the Paketo Slack: https://paketo.io/community/

@bclozel bclozel added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged for: team-meeting An issue we'd like to discuss as a team to make progress status: waiting-for-internal-feedback An issue that needs input from a member or another Spring Team labels Jan 29, 2025
@bclozel bclozel added this to the 3.5.x milestone Jan 29, 2025
@mhalbritter mhalbritter self-assigned this Feb 19, 2025
@mhalbritter mhalbritter modified the milestones: 3.5.x, 3.5.0-M2 Feb 19, 2025
@mhalbritter
Copy link
Contributor

Our system tests fail when using the noble tiny image, see this build scan.

ERROR: failed to launch: bash exec: no such file or directory

The tiny image contains no shell and there are no non-tiny images for noble available yet. Maybe we can rewrite the test to not need a shell.

mhalbritter added a commit that referenced this issue Feb 19, 2025
These tests need a shell, which is not available in the noble tiny
image. There are no non-tiny images for noble available yet.

See gh-42711
@mhalbritter
Copy link
Contributor

mhalbritter commented Feb 19, 2025

org.springframework.boot.image.paketo.PaketoBuilderTests#plainWarApp fail when using noble tiny image.

ERROR: failed to launch: path lookup: exec: "sh": executable file not found in $PATH

When using paketobuildpacks/builder-jammy-java-tiny:latest, this works.

mhalbritter added a commit that referenced this issue Feb 19, 2025
@mhalbritter mhalbritter reopened this Feb 19, 2025
@mhalbritter mhalbritter modified the milestones: 3.5.0-M2, 3.5.x Feb 19, 2025
@mhalbritter
Copy link
Contributor

I've reverted the changes until this problem is investigated.

@mhalbritter
Copy link
Contributor

mhalbritter commented Feb 24, 2025

The Tomcat buildpack has some special cases for the tiny images, and right now only bionic and jammy is supported. I've opened paketo-buildpacks/apache-tomcat#531. That's the reason org.springframework.boot.image.paketo.PaketoBuilderTests#plainWarApp fails.

TomEE is also affected: paketo-buildpacks/apache-tomee#309.

There's also a special case for native image, i've opened paketo-buildpacks/native-image#361 for that.

There's also special handling if no shell is available in procfile, see paketo-buildpacks/procfile#266.

@mhalbritter mhalbritter added the status: blocked An issue that's blocked on an external project change label Feb 24, 2025
@mhalbritter
Copy link
Contributor

All the issues are closed, however the images aren't on DockerHub yet. There's also this PR, which AFAIK, adds the missing paketobuildpacks/builder-noble-base:latest.

@philwebb
Copy link
Member

philwebb commented Apr 2, 2025

The PR has been merged, but I don't see images on https://hub.docker.com/r/paketobuildpacks/build-noble-base/tags yet.

@mhalbritter
Copy link
Contributor

I think they have disabled the CI workflows and want to re-enable them after paketo-buildpacks/ubuntu-noble-base-images#1 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked An issue that's blocked on an external project change type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

8 participants