Skip to content

Use local docker mirror for test containers #24343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Dec 7, 2020 · 4 comments
Closed

Use local docker mirror for test containers #24343

philwebb opened this issue Dec 7, 2020 · 4 comments
Labels
status: superseded An issue that has been superseded by another type: task A general task

Comments

@philwebb
Copy link
Member

philwebb commented Dec 7, 2020

We might be able to use the local docker mirror that is configured in concourse for test containers. I think we'd need a custom ImageNameSubstitutor and also a custom docker login.
@philwebb philwebb added the type: task A general task label Dec 7, 2020
@philwebb philwebb added this to the 2.2.x milestone Dec 7, 2020
@ttddyy
Copy link
Contributor

ttddyy commented Dec 7, 2020

@philwebb In my project, I have this implementation for image name substitution, fyi.
(Testcontainers issue comment)

@bsideup
Copy link
Contributor

bsideup commented Dec 8, 2020

@philwebb if you configure your mirror like this, it would work out of the box:
https://docs.docker.com/registry/recipes/mirror/

@philwebb philwebb modified the milestones: 2.2.x, 2.4.x Jun 15, 2021
@wilkinsona wilkinsona modified the milestones: 2.4.x, 2.5.x Nov 15, 2021
philwebb added a commit that referenced this issue Nov 19, 2021
@philwebb
Use local docker mirror for test containers
902dd0b 
See gh-24343
@philwebb
Copy link
Member Author

Trying something on main. If it's stable we can backport.

@wilkinsona
Copy link
Member

Backported as part of 429167e for gh-25135.

@wilkinsona wilkinsona removed this from the 2.5.x milestone Mar 11, 2022
@wilkinsona wilkinsona added the status: superseded An issue that has been superseded by another label Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ttddyy @philwebb @wilkinsona @bsideup