Skip to content

Validate our own tests work with JUnit5 and the vintage engine #14737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Oct 9, 2018 · 0 comments
Closed

Validate our own tests work with JUnit5 and the vintage engine #14737

philwebb opened this issue Oct 9, 2018 · 0 comments
Assignees
@snicoll @mbhave
Labels
theme: testing Issues related to testing type: task A general task
Milestone
2.2.0.M3

Comments

@philwebb
Copy link
Member

philwebb commented Oct 9, 2018 •
edited
Loading

We should upgrade our own tests so we know what's involved and to help us decided how to do #14736.
@philwebb philwebb added the type: task A general task label Nov 16, 2018
@philwebb philwebb added this to the 2.2.x milestone Nov 16, 2018
mbhave added a commit to mbhave/spring-boot that referenced this issue Dec 5, 2018
@mbhave
Upgrade tests to Junit5
9fdbb0e 
See spring-projectsgh-14737
mbhave added a commit to mbhave/spring-boot that referenced this issue Dec 6, 2018
@mbhave
Upgrade tests to Junit5
9a6bbc3 
See spring-projectsgh-14737
mbhave added a commit that referenced this issue Dec 6, 2018
@mbhave
Upgrade tests to Junit5
59d2b0a 
See gh-14737
@wilkinsona wilkinsona added the status: blocked An issue that's blocked on an external project change label Dec 12, 2018
wilkinsona added a commit that referenced this issue Dec 12, 2018
@wilkinsona
Move back to JUnit 4 until SUREFIRE-1614 has been resolved
064f647 
See gh-14736
See gh-14737
See gh-14738
@snicoll snicoll added the theme: testing Issues related to testing label Feb 21, 2019
snicoll added a commit to snicoll/spring-boot that referenced this issue May 6, 2019
@snicoll
Migrate tests to JUnit 5
abffe80 
See spring-projectsgh-14737
mbhave added a commit to mbhave/spring-boot that referenced this issue May 7, 2019
@mbhave
Upgrade tests to Junit5
36ead5b 
See spring-projectsgh-14737
snicoll added a commit to snicoll/spring-boot that referenced this issue May 7, 2019
@mbhave @snicoll
Upgrade tests to Junit5
2c48947 
See spring-projectsgh-14737

Co-authored-by: Stephane Nicoll <snicoll@pivotal.io>
snicoll added a commit to snicoll/spring-boot that referenced this issue May 7, 2019
@mbhave @snicoll
Upgrade tests to Junit5
70045bc 
See spring-projectsgh-14737

Co-authored-by: Stephane Nicoll <snicoll@pivotal.io>
@snicoll snicoll removed the status: blocked An issue that's blocked on an external project change label May 7, 2019
snicoll added a commit to snicoll/spring-boot that referenced this issue May 7, 2019
@mbhave @snicoll
Upgrade tests to Junit5
cf74aaa 
See spring-projectsgh-14737

Co-authored-by: Stephane Nicoll <snicoll@pivotal.io>
@mbhave mbhave changed the title Upgrade our own tests to JUnit 5 Validate our own tests work with JUnit5 and the vintage engine May 7, 2019
mbhave added a commit to mbhave/spring-boot that referenced this issue May 8, 2019
@mbhave @snicoll
Upgrade tests to Junit5
5d4a6a8 
See spring-projectsgh-14737

Co-authored-by: Stephane Nicoll <snicoll@pivotal.io>
@snicoll snicoll closed this as completed in 1db1c8b May 8, 2019
@snicoll snicoll modified the milestones: 2.2.x, 2.2.0.M3 May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

@mbhave mbhave

Labels
theme: testing Issues related to testing type: task A general task
Projects
None yet
Milestone
2.2.0.M3
Development

No branches or pull requests
4 participants
@snicoll @philwebb @wilkinsona @mbhave