Skip to content

Add String to primitive list #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Add String to primitive list #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/super_diff.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def self.date_like?(value)

def self.primitive?(value)
case value
when true, false, nil, Symbol, Numeric, Regexp, Class
when true, false, nil, Symbol, Numeric, Regexp, Class, String
true
else
false
Expand Down
2 changes: 1 addition & 1 deletion lib/super_diff/basic/inspection_tree_builders/primitive.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module Basic
module InspectionTreeBuilders
class Primitive < Core::AbstractInspectionTreeBuilder
def self.applies_to?(value)
SuperDiff.primitive?(value) || value.is_a?(::String)
SuperDiff.primitive?(value)
end

def call
Expand Down
2 changes: 1 addition & 1 deletion lib/super_diff/equality_matchers/defaults.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
module SuperDiff
module EqualityMatchers
DEFAULTS = [
Primitive,
Array,
Hash,
MultilineString,
SinglelineString,
Primitive,
Default
].freeze
end
Expand Down