Skip to content

fix CustomBlockComponentProps blockValue type #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2021
Merged

fix CustomBlockComponentProps blockValue type #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ export type BlockValueProp<T> = Extract<BlockValueType, { type: T }>;
export interface CustomBlockComponentProps<T extends BlockValueTypeKeys> {
renderComponent: () => JSX.Element | null;
blockMap: BlockMapType;
blockValue: T extends BlockValueType ? BlockValueProp<T> : BaseValueType;
Copy link
Contributor Author

@sorcererxw sorcererxw Aug 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since BlockValueTypeKeys is union of string, but BlockValueType not, T would never match BlockValueTypeKeys & BlockValueType

blockValue: T extends BlockValueTypeKeys ? BlockValueProp<T> : BaseValueType;
level: number;
}

Expand Down