Skip to content

Fixes for checking for ack packet only #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

aberridg
Copy link
Contributor

@aberridg aberridg commented Jul 1, 2021

This should fix the issues with the non-working examples... Added the "true" statements in the right places. Also added a little more debugging so I could more clearly see what was going on when things weren't working.

Not tested fully as it's been a long day :-)

Let me know!

Andrew

@PaulZC
Copy link
Collaborator

PaulZC commented Jul 3, 2021

Thank you Andrew - merging for testing...
All the best,
Paul

@PaulZC PaulZC merged commit 7f2384b into sparkfun:release_candidate_v2.1_modified_state_management Jul 3, 2021
@PaulZC
Copy link
Collaborator

PaulZC commented Jul 3, 2021

Hi Andrew,
I'm making progress with this... But I'm still not quite there.
I had to make some alterations to let Example20 run. But that is working now.
I'm currently struggling with Example21 which uses a large custom packet to retrieve the module information.
It should return something like this:

image

But with the new code, it fails:

image

There is something subtlety different about which buffer is being used. I think I'm possibly using the wrong buffer...
I shall keep digging!
More later,
Paul

@aberridg
Copy link
Contributor Author

aberridg commented Jul 3, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants