Skip to content

Bug fixes to support actual use. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2023
Merged

Bug fixes to support actual use. #3

merged 3 commits into from
Nov 4, 2023

Conversation

@gigapod
Copy link
Member

@gigapod gigapod commented Nov 4, 2023

Contains the following fixes:

  • Arduino begin() methods should return bools, not ints
  • The Arduino begin() methods were always returning 0 - not actual status
  • The Arduino header file include SFE_Bus.h, when the file is sfe_bus.h -- so doesn't work on non-windows platforms
  • Make a Arduino/Qwiic I2C address macro -- for use outside of this library.

@gigapod
version bump
753c6b0
@gigapod
made a *standard* I2C address macro that can be used outside of this …
c094871 
…library
@gigapod
moved begin() methods to a) standard type of bools and b) now they ac…
fa3facb 
…tually return a status - not always 0; makes use of the new macro for address; sfe_bus.h is now using proper case - lower - which is important for linux/unix/macos
@gigapod gigapod merged commit da626ed into main Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gigapod @PaulKyros