Development 2 Branch merge to Main post Code Review #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial upload to new branch - currently working to determine what the error between development and main branches is
Working through isolating the presence detection - all work is now correct and can run the presence code successfully
Code has been reviewed and now functional and ready for design review. Going to make small changes to comments, but code is pretty ready to go.
See code review comments doc for more details
Reorganizing file structure to be correct
Restructuring folders - should be fixed
For more finite details, see code review document for changes made. Mostly final small tweaks to the code; updated README file
Ready for final PR
Comments from Dryw in chat- examples are now functional and ready for merge
sfe-SparkFro
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code has been reviewed and is now ready for merge to main branch.