Enable cppcoreguidelines-pro-bounds-pointer-arithmetic #1900
Conversation
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
src/core/yaml/yaml.cc
Outdated
| @@ -1,4 +1,5 @@ | |||
| // See https://pyyaml.org/wiki/LibYAML for basic documentation | |||
| #include <span> | |||
There was a problem hiding this comment.
Can you put this include after a new line after <sourcemeta/core/io.h> and put the usual // std::span comment?
There was a problem hiding this comment.
@jviotti Does the llvm clang-tidy check https://clang.llvm.org/extra/clang-tidy/checks/llvm/include-order.html serve this purpose? When I looked at it, it sounded specific to llvm project. Another pair of eyes doesn't harm.
There was a problem hiding this comment.
or do we have any clang-format rule for this?
There was a problem hiding this comment.
Does the llvm clang-tidy check https://clang.llvm.org/extra/clang-tidy/checks/llvm/include-order.html serve this purpose? When I looked at it, it sounded specific to llvm project. Another pair of eyes doesn't harm.
Yeah, that'd be great. I'd be OK with removing all of these comments once we have a check that covers all of these cases and we are confident that works well.
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
|
@jviotti PTAL |
2 participants
No description provided.