Fix/clear callback bug #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejmakowski2003
requested review from
mdydek,
michalsek,
miloszwielgus,
poneciak57 and
vltkv
added 2 commits
November 3, 2025 20:45
mdydek
requested changes
Nov 4, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioScheduledSourceNode.cpp
Show resolved
Hide resolved
mdydek
approved these changes
Nov 4, 2025
poneciak57
requested changes
Nov 5, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/sources/AudioBufferBaseSourceNode.cpp
Show resolved
Hide resolved
poneciak57
approved these changes
Nov 5, 2025
mdydek
pushed a commit
that referenced
this pull request
Nov 5, 2025
* chore: clang code/formatting issues * chore: linting * fix: thread safe callbacks in source nodes * ci: lint * fix: nitpicks * chore: pods --------- Co-authored-by: maciejmakowski2003 <maciej.makowski2608@gmail.com>
poneciak57
pushed a commit
that referenced
this pull request
Nov 5, 2025
* chore: clang code/formatting issues * chore: linting * fix: thread safe callbacks in source nodes * ci: lint * fix: nitpicks * chore: pods --------- Co-authored-by: maciejmakowski2003 <maciej.makowski2608@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #717
Closes RNAA-269
Introduced changes
Checklist