Skip to content

fix: flag fix #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

fix: flag fix #775

merged 1 commit into from
Oct 31, 2025

Conversation

@mdydek
Copy link
Contributor

@mdydek mdydek commented Oct 31, 2025

Closes #

⚠️ Breaking changes ⚠️

Introduced changes

  • this pr fixes wrong handling of stop, it made streaming thread to stop immediately, not waiting for node to reach finished state

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web

@mdydek mdydek added the fix label Oct 31, 2025
@mdydek mdydek self-assigned this Oct 31, 2025
michalsek
michalsek approved these changes Oct 31, 2025
View reviewed changes
Copy link
Member

@michalsek michalsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍎

@mdydek mdydek merged commit 160484c into main Oct 31, 2025
3 checks passed
@mdydek mdydek deleted the fix/calling-stop-on-streamer branch October 31, 2025 08:46
poneciak57 pushed a commit that referenced this pull request Nov 5, 2025
@mdydek @poneciak57
fix: flag fix (#775)
cd4e9fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsek michalsek michalsek approved these changes

@poneciak57 poneciak57 poneciak57 approved these changes

Assignees

@mdydek mdydek

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdydek @michalsek @poneciak57