feat: option to disable avaudiosession configuration / management #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miloszwielgus
requested review from
maciejmakowski2003,
mdydek,
michalsek,
poneciak57 and
vltkv
mdydek
requested changes
Oct 29, 2025
Contributor
mdydek
left a comment
mdydek
left a comment
There was a problem hiding this comment.
There should be method named disableSessionManagement also in android apiModule, otherwise code will only be valid on ios, even though there is not equivalent option on android side, refer f.e. to setAudioSessionActivity
poneciak57
approved these changes
Oct 29, 2025
vltkv
approved these changes
Oct 29, 2025
maciejmakowski2003
approved these changes
Oct 31, 2025
michalsek
approved these changes
Oct 31, 2025
mdydek
approved these changes
Oct 31, 2025
poneciak57
pushed a commit
that referenced
this pull request
Nov 5, 2025
* feat: native impl of disableSessionManagement * feat: ts api for disableSessionManagement * feat: docs * feat: add empty method for android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RNAA-258
Introduced changes
Implemented
AudioManager.disableSessionManagement, it sets an internal flag which stops the package from managing theAVAudioSessionallowing the user to manage it.Checklist