Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: simonseyock/php-cross-domain-proxy
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: softius/php-cross-domain-proxy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 1 file changed
  • 2 contributors

Commits on Sep 20, 2018

  1. Duplicate headers

    PHP (7.1.16) was showing `Content-Type` and `Content-Length` with both their original name and preceded by `HTTP`:
    ```
    CONTENT_TYPE
    HTTP_CONTENT_TYPE
    CONTENT_LENGTH
    HTTP_CONTENT_LENGTH
    ```
    
    This was causing the headers to be added as duplicates in the request_headers array. Removing the 'CONTENT' condition to prevent the duplicate addition.
    jweisman committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    f9bd83b View commit details
    Browse the repository at this point in the history
  2. Remove Expect header

    Remove the `Expect` header which is [not handled](https://blog.pilif.me/2007/02/02/the-return-of-except-100-continue/) by many hosts (including the API gateway apparently).
    jweisman committed Sep 20, 2018
    Configuration menu
    Copy the full SHA
    392a417 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2018

  1. Restore CONTENT headers and add variable for Expect

    Restore CONTENT headers- it seems that from some clients PHP doesn't have the duplicate headers. Consider adding an `array_unique` to clean header array
    
    Wrap handling of Expect header in config variable.
    jweisman committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    14175fd View commit details
    Browse the repository at this point in the history
  2. Merge pull request softius#34 from jweisman/master

    Add option to suppress Expect: 100-continue header
    softius authored Sep 21, 2018
    Configuration menu
    Copy the full SHA
    be37139 View commit details
    Browse the repository at this point in the history
Loading