Add option to suppress Expect: 100-continue header #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP (7.1.16) was showing `Content-Type` and `Content-Length` with both their original name and preceded by `HTTP`: ``` CONTENT_TYPE HTTP_CONTENT_TYPE CONTENT_LENGTH HTTP_CONTENT_LENGTH ``` This was causing the headers to be added as duplicates in the request_headers array. Removing the 'CONTENT' condition to prevent the duplicate addition.
Remove the `Expect` header which is [not handled](https://blog.pilif.me/2007/02/02/the-return-of-except-100-continue/) by many hosts (including the API gateway apparently).
Restore CONTENT headers- it seems that from some clients PHP doesn't have the duplicate headers. Consider adding an `array_unique` to clean header array Wrap handling of Expect header in config variable.
softius
approved these changes
Sep 21, 2018
Owner
|
Thank you @jweisman for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. Great little script. Thanks for it.
We've added a configuration option to suppress the
Expect: 100-continueheader which CURL adds automatically but which is not handled correctly by some web servers. Would be grateful if you'd consider merging this into master.Thanks!