Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.5.1
Choose a base ref
...
head repository: socketio/socket.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.5.2
Choose a head ref
  • 7 commits
  • 30 files changed
  • 3 contributors

Commits on May 25, 2022

  1. fix: prevent the socket from joining a room after disconnection

    Calling `socket.join()` after disconnection would lead to a memory
    leak, because the room was never removed from the memory:
    
    ```js
    io.on("connection", (socket) => {
      socket.disconnect();
      socket.join("room1"); // leak
    });
    ```
    
    Related:
    
    - #4067
    - #4380
    darrachequesne committed May 25, 2022
    Configuration menu
    Copy the full SHA
    18f3fda View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. chore: bump mocha to version 10.0.0

    Related: #3710
    darrachequesne committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    713a6b4 View commit details
    Browse the repository at this point in the history
  2. chore: bump dependencies

    Production:
    
    - socket.io-parser: ~4.0.4 => ~4.2.0
    
    Development:
    
    - superagent: ^6.1.0 => ^8.0.0
    - tsd: ^0.17.0 => ^0.21.0
    
    Related: #3709
    darrachequesne committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    9890b03 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Configuration menu
    Copy the full SHA
    134226e View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2022

  1. Configuration menu
    Copy the full SHA
    2803871 View commit details
    Browse the repository at this point in the history
  2. fix(uws): prevent the server from crashing after upgrade

    This should fix a rare case where the Engine.IO connection was upgraded
    to WebSocket while the Socket.IO socket was disconnected, which would
    result in the following exception:
    
    > TypeError: Cannot read properties of undefined (reading 'forEach')
    >    at subscribe (/node_modules/socket.io/dist/uws.js:87:11)
    >    at Socket.<anonymous> (/node_modules/socket.io/dist/uws.js:28:17)
    >    at Socket.emit (node:events:402:35)
    >    at WebSocket.onPacket (/node_modules/engine.io/build/socket.js:214:22)
    >    at WebSocket.emit (node:events:390:28)
    >    at WebSocket.onPacket (/node_modules/engine.io/build/transport.js:92:14)
    >    at WebSocket.onData (/node_modules/engine.io/build/transport.js:101:14)
    >    at message (/node_modules/engine.io/build/userver.js:56:30)
    
    Related: #4443
    darrachequesne committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    ba497ee View commit details
    Browse the repository at this point in the history
  3. chore(release): 4.5.2

    darrachequesne committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    8be95b3 View commit details
    Browse the repository at this point in the history
Loading