Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 66e4fdf
Choose a base ref
...
head repository: socketio/socket.io-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 085cd6c
Choose a head ref
  • 6 commits
  • 18 files changed
  • 3 contributors

Commits on Nov 20, 2020

  1. Configuration menu
    Copy the full SHA
    b3de861 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2020

  1. ci: migrate to GitHub Actions

    Due to the recent changes to the Travis CI platform (see [1]), we will
    now use GitHub Actions to run the tests.
    
    Reference: https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-nodejs
    
    [1]: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
    darrachequesne committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    adffc03 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    226b491 View commit details
    Browse the repository at this point in the history
  3. fix: emit an error when reaching a v2.x server

    A WebSocket-only v3.x client is able to reach a v2.x server, as the
    Engine.IO handshake are compatible, but the v2.x server does not send
    a sid in the Socket.IO handshake, which resulted in:
    
    > Uncaught TypeError: Cannot read property 'sid' of undefined
    
    A 'connect_error' event will now be emitted.
    
    References:
    
    - https://github.com/socketio/engine.io-protocol#difference-between-v3-and-v4
    - https://github.com/socketio/socket.io-protocol#difference-between-v5-and-v4
    - https://socket.io/docs/v3/migrating-from-2-x-to-3-0/
    darrachequesne committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    ec1f8c3 View commit details
    Browse the repository at this point in the history
  4. fix: keep track of active sockets

    When a given socket was disconnected, either by the server-side or by the client-side, the manager was closed too, regardless of the other connected sockets.
    
    ```js
    const socket1 = io({
      autoConnect: false
    });
    const socket2 = io("/test");
    
    socket1.disconnect(); // also disconnect socket2
    ```
    
    This bug was introduced in [1].
    
    [1]: b60e909
    darrachequesne committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    f8f60fc View commit details
    Browse the repository at this point in the history
  5. chore(release): 3.0.4

    darrachequesne committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    085cd6c View commit details
    Browse the repository at this point in the history
Loading