Fix #670 by removing all None values from dict#671
Merged
seratch merged 1 commit intoslackapi:masterfrom May 11, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
+ Coverage 87.17% 87.21% +0.04%
==========================================
Files 15 15
Lines 1824 1830 +6
Branches 100 106 +6
==========================================
+ Hits 1590 1596 +6
Misses 202 202
Partials 32 32
Continue to review full report at Codecov.
|
Contributor
Author
|
This is safe enough. Let me merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes #670 by scanning None values from data, files, and params. There is no reason to keep them as they'll just result in TypeError.
After applying this change, the new sync mode WebClient in #662 also needs to be updated in the same manner.
Requirements (place an
xin each[ ])