Skip to content

Conversation

@simPod
Copy link
Owner

@simPod simPod commented Oct 29, 2025

No description provided.

@simPod simPod requested a review from Copilot October 29, 2025 08:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the consumer shutdown mechanism by extracting a new stop() method and resetting the shouldRun flag when starting the consumer.

  • Extracted stop() method that sets shouldRun to false, called from shutdown()
  • Added initialization of shouldRun = true at the start of doStart() to ensure clean state on each start

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.96%. Comparing base (9c2f544) to head (4e76144).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
+ Coverage   71.36%   71.96%   +0.60%     
==========================================
  Files           9        9              
  Lines         213      214       +1     
==========================================
+ Hits          152      154       +2     
+ Misses         61       60       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@simPod simPod requested a review from Copilot October 29, 2025 08:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@simPod simPod merged commit 8ebdd08 into master Oct 29, 2025
14 checks passed
@simPod simPod deleted the stop branch October 29, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants