feat: drop final from KafkaProducerWrapper

[simPod]

Allows lazy proxy generation

Summary by CodeRabbit

• Refactor
  • Updated class structure to allow for future extensions while maintaining immutability of properties.
• Chores
  • Adjusted configuration settings to improve code quality thresholds.

[coderabbitai]

Walkthrough

The class declaration for KafkaProducerWrapper was modified to remove the final keyword, making it possible to extend this class. The readonly modifier remains, ensuring immutability of its properties. No other code or logic changes were made. Additionally, the "minMsi" value in the infection.json.dist configuration was lowered from 35 to 31.

Changes

File	Change Summary
src/Clients/Producer/KafkaProducerWrapper.php	Changed class from final readonly to readonly.
infection.json.dist	Lowered "minMsi" value from 35 to 31.

Estimated code review effort

1 (~5 minutes)

Possibly related PRs

• feat: introduce KafkaProducerWrapper #228: Originally introduced the KafkaProducerWrapper class as a final readonly class; both PRs modify the same class declaration in the same file.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a5c631b and 8ef700d.

📒 Files selected for processing (2)

• infection.json.dist (1 hunks)
• src/Clients/Producer/KafkaProducerWrapper.php (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• infection.json.dist

🚧 Files skipped from review as they are similar to previous changes (1)

• src/Clients/Producer/KafkaProducerWrapper.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: Coding Standards
• GitHub Check: PHPUnit (lowest, 8.3)
• GitHub Check: Static Analysis with PHPStan
• GitHub Check: PHPUnit (8.4, highest)
• GitHub Check: PHPUnit (8.3, highest)
• GitHub Check: Infection

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/Clients/Producer/KafkaProducerWrapper.php (2)

52-56: Guard against null before the numeric comparison
Comparing null < 0 works today but is fragile and may trigger deprecation notices in future PHP versions.

-if ($partition < 0) {
+if ($partition !== null && $partition < 0) {

---

22-22: Re-consider exposing $producer as public
With the class now extendable, a publicly mutable reference to the underlying RdKafka\Producer slightly weakens encapsulation—even though it’s readonly. Promoting it to private (with a getter) would keep the surface minimal and forbid direct method calls that bypass wrapper invariants.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5788999 and a5c631b.

📒 Files selected for processing (1)

• src/Clients/Producer/KafkaProducerWrapper.php (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: Static Analysis with PHPStan
• GitHub Check: Infection
• GitHub Check: PHPUnit (lowest, 8.3)
• GitHub Check: PHPUnit (8.3, highest)
• GitHub Check: Coding Standards
• GitHub Check: PHPUnit (8.4, highest)

🔇 Additional comments (1)

src/Clients/Producer/KafkaProducerWrapper.php (1)

18-18: final removal looks good and unlocks proxying use-cases
No functional or BC issues spotted; keeping the readonly modifier preserves immutability.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (5788999) to head (8ef700d).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   70.40%   70.40%           
=======================================
  Files           9        9           
  Lines         223      223           
=======================================
  Hits          157      157           
  Misses         66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.