Skip to content

Change dropdown to work on hover instead of on click #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 5, 2020
Merged

Change dropdown to work on hover instead of on click #62

merged 8 commits into from
Aug 5, 2020

Conversation

Bgreen23
Copy link

@Bgreen23 Bgreen23 commented Aug 5, 2020

No description provided.

@Bgreen23 Bgreen23 marked this pull request as ready for review August 5, 2020 19:55
@Bgreen23 Bgreen23 requested a review from patmellon August 5, 2020 19:58
patmellon
patmellon approved these changes Aug 5, 2020
View reviewed changes
Copy link

@patmellon patmellon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The top of the dropdown is now closer to the nav link above it, so I wonder if they'll want to adjust that. Otherwise, though, it looks good to go.

@Bgreen23 Bgreen23 merged commit f022718 into main-nav-updates Aug 5, 2020
@Bgreen23 Bgreen23 deleted the hover-main-nav branch August 13, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmellon patmellon patmellon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bgreen23 @patmellon