Skip to content

Conversation

thbourlove
Copy link
Contributor

No description provided.

@complex857
Copy link
Collaborator

Thanks for the patch. I'm not 100% sure what it supposed to fix exactly. Can you confirm it for me that the scenario it should fix is something like this (so i can add a unit test for this):

namespace Foo;
filter_v // <- hitting <c-x><c-o> here should offer completions

Now it only seem to work when explicitly prefixed with \ however PHP do find the functions as expected without it.

@thbourlove
Copy link
Contributor Author

@complex857 It won't offer completions without this patch.

complex857 pushed a commit that referenced this pull request Dec 25, 2013
Show completions for built-in  functions, keywords, constants when in namespaces without explicitly prefixing the base with \
@complex857 complex857 merged commit e8be546 into shawncplus:master Dec 25, 2013
complex857 pushed a commit that referenced this pull request Dec 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants