Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input-otp): add disabled appearance (with example) #2938

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

guilhermerodz
Copy link

@guilhermerodz guilhermerodz commented Mar 7, 2024

Commits

  • feat(input-otp): add :disabled modifier for appearance
  • docs(input-otp): add example for disabled prop
  • fix(input-otp): use containerClassName and className correctly

I followed your code standards as much as I can. What I did:

  • Create new example for :disabled modifier in Markdown + registry.
  • Decreased to opacity-30 when :disabled modifier, just like you do it with the existent component
  • Edited input-otp.json in both new-york and default registries.
  • Updated input-otp to latest (as of now 1.1.0)
  • Updated pnpm-lock

New example: Disabled

CleanShot.2024-03-07.at.16.55.23.mp4

Copy link

vercel bot commented Mar 7, 2024

@guilhermerodz is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@guilhermerodz guilhermerodz marked this pull request as draft March 7, 2024 19:59
@guilhermerodz guilhermerodz marked this pull request as ready for review March 7, 2024 20:07
@guilhermerodz guilhermerodz changed the title feat/add disabled modifier to input otp feat/add disabled modifier and example to input otp Mar 7, 2024
@guilhermerodz guilhermerodz force-pushed the feat/add-disabled-modifier-to-input-otp branch from 2d02675 to 66ea0ad Compare March 11, 2024 09:51
@guilhermerodz
Copy link
Author

guilhermerodz commented Mar 11, 2024

@shadcn I believe this is the right way to use input-otp. I created this PR so that you can update everything accordingly.

Feel free to merge.

I doubled checked demo, registry, and also updated input-otp to latest in package.json.

@guilhermerodz guilhermerodz changed the title feat/add disabled modifier and example to input otp feat: add disabled appearance (with example) Mar 11, 2024
@guilhermerodz guilhermerodz changed the title feat: add disabled appearance (with example) feat(input-otp): add disabled appearance (with example) Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants