Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aria-disabled to button component #2921

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abdulbasithqb
Copy link

This commit enhances the Button component by adding the aria-disabled attribute when the disabled prop is set to true. This addition improves accessibility for users relying on assistive technologies by conveying the disabled state information. The change ensures consistency between the visual state and accessibility properties.

Affected component/components

Button

fixes: #2917

Copy link

vercel bot commented Mar 6, 2024

@abdulbasithqb is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat]: add aria-disabled to button component
1 participant