make set_rsa_oaep_md visible to boringssl config #2372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
approved these changes
Feb 19, 2025
|
Looks like there's an import that needs to be included for boringssl as well. |
Upstreaming https://android-review.git.corp.google.com/c/platform/external/rust/crates/openssl/+/2177444 Android's KeyMint is [using](https://android.googlesource.com/platform/system/keymint/+/refs/heads/main/boringssl/src/rsa.rs#164) this function and it uses rust-openssl with boringssl, but via a downstream patch
frncs-rss
force-pushed
the
set_rsa_oaep_md
branch
from
8b150cf to
77de94f
Compare
Good catch. I missed the test section had its own imports. Amended. |
alex
approved these changes
Feb 19, 2025
bherrera
pushed a commit
to misttech/fuchsia
that referenced
this pull request
Mar 12, 2025
we temporarily need 2 patches: 1. encrypt.rs: sfackler/rust-openssl#2372 already upstream waiting for the next quarterly release 2. ec.rs: sfackler/rust-openssl#2371 rejected upstream waiting to be inlined into KeyMint tracked by https://fxbug.dev/398863191 Fixed: 395970649 Change-Id: I12a795f645b74297948eddb6baaa8ca44df7404d Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1219109 Reviewed-by: Erick Tryzelaar <etryzelaar@google.com> Commit-Queue: Francois Rousseau <frousseau@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming https://android-review.git.corp.google.com/c/platform/external/rust/crates/openssl/+/2177444
Android's KeyMint is using this function and it uses rust-openssl with boringssl, but via a downstream patch