added comment support, fixed enabled state update #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eahefnawy
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
Thanks @evgsil ... looks good, would love some extra eyes from @danielcondemarin here 😊
danielcondemarin
approved these changes
Sep 26, 2019
danielcondemarin
approved these changes
Oct 5, 2019
thiagozf
pushed a commit
to thiagozf/aws-cloudfront
that referenced
this pull request
Apr 28, 2020
…comment added comment support, fixed enabled state update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is crucial for me to have ability to specify distribution comment. It allows you easily mark and recognize distributions for different projects, stages etc.
Also fixed situation when distribution should be enabled/disabled without other changes