Skip to content

fix(data): strengthen event argument checks and add explicit type annotations #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(data): strengthen event argument checks and add explicit type annotations #1036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/data/src/viem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,11 @@ export default class SemaphoreViem {
const memberUpdatedEventsMap = new Map<string, [bigint, string]>()

for (const event of memberUpdatedEvents) {
if (event.args.index && event.args.newIdentityCommitment && event.blockNumber) {
if (
event.args.index !== undefined &&
event.args.newIdentityCommitment !== undefined &&
event.blockNumber !== undefined
) {
memberUpdatedEventsMap.set(event.args.index.toString(), [
event.blockNumber,
event.args.newIdentityCommitment.toString()
Expand All @@ -266,7 +270,7 @@ export default class SemaphoreViem {
}

for (const event of memberRemovedEvents) {
if (event.args.index && event.blockNumber) {
if (event.args.index !== undefined && event.blockNumber !== undefined) {
const groupUpdate = memberUpdatedEventsMap.get(event.args.index.toString())

if (!groupUpdate || (groupUpdate && groupUpdate[0] < event.blockNumber)) {
Expand All @@ -289,10 +293,10 @@ export default class SemaphoreViem {
const membersAddedEventsMap = new Map<string, string[]>()

for (const event of membersAddedEvents) {
if (event.args.startIndex && event.args.identityCommitments) {
if (event.args.startIndex !== undefined && Array.isArray(event.args.identityCommitments)) {
membersAddedEventsMap.set(
event.args.startIndex.toString(),
event.args.identityCommitments.map((i) => i.toString())
event.args.identityCommitments.map((i: string) => i.toString())
)
}
}
Expand Down Expand Up @@ -324,7 +328,7 @@ export default class SemaphoreViem {
const currentIndex = index // Create a closure to capture the current index value
const event = memberAddedEvents.find((e) => Number(e.args.index) === currentIndex)

if (event && event.args.identityCommitment) {
if (event && event.args.identityCommitment !== undefined) {
members.push(event.args.identityCommitment.toString())
}

Expand Down