Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include traits in event payload, even if empty. #384

Merged
merged 5 commits into from
Mar 19, 2025

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Mar 19, 2025

  • Made traits non-optional in state.
  • Updated call points to provide an empty object where it was nil.
  • Updated tests to accurately test fresh instance as well as reset.
  • Removed out of date Windows/Linux tests.

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (59ae167) to head (77bdd7e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   71.12%   70.13%   -1.00%     
==========================================
  Files          48       48              
  Lines        4894     4795      -99     
==========================================
- Hits         3481     3363     -118     
- Misses       1413     1432      +19     
Files with missing lines Coverage Δ
Sources/Segment/Analytics.swift 84.52% <100.00%> (-0.41%) ⬇️
Sources/Segment/State.swift 95.87% <100.00%> (-2.07%) ⬇️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsneed bsneed merged commit 569344f into main Mar 19, 2025
11 checks passed
@bsneed bsneed deleted the bsneed/empty_traits branch March 19, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants