Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

36 refactoring #93

Merged
merged 10 commits into from
Sep 5, 2023
Merged

36 refactoring #93

merged 10 commits into from
Sep 5, 2023

Conversation

Weltraumschaf
Copy link
Member

No description provided.

@Weltraumschaf
secureCodeBox#36 Add tests for auth header generation
c0feea3 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
secureCodeBox#36 USe better name forfacotry method
cb4352d 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
secureCodeBox#36 Simplify syntax of method
a238f26 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
secureCodeBox#36 Decompose method to make code testable
97d74cb 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
secureCodeBox#36 Decompose method to make code testable
b557e84 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
secureCodeBox#36 Decompose method to make code testable
7696009 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf Weltraumschaf marked this pull request as draft September 4, 2023 20:29
@Weltraumschaf Weltraumschaf self-assigned this Sep 4, 2023
@Weltraumschaf Weltraumschaf added the enhancement New feature or request label Sep 4, 2023
@Weltraumschaf
secureCodeBox#36 Reformatting
386d1a6 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
secureCodeBox#36 Decompose method to make code testable
be1437d 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
secureCodeBox#36 Use method chaining for better readability
943769b 
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf
secureCodeBox#36 We assume a configured proxy only if username/passwo…
8c053c9 
…rd are set

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf Weltraumschaf marked this pull request as ready for review September 5, 2023 07:59
@Weltraumschaf Weltraumschaf merged commit b8654ca into secureCodeBox:main Sep 5, 2023
@Weltraumschaf Weltraumschaf deleted the 36_refactoring branch September 5, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zero3141 Zero3141 Zero3141 approved these changes

Assignees

@Weltraumschaf Weltraumschaf

Labels
enhancement New feature or request
Projects
secureCodeBox v4
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Weltraumschaf @Zero3141