Re-add test action #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heiko Kiesel <45092958+Zero3141@users.noreply.github.com>
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
|
Why is this not covered by ci.yaml? |
The ci.yaml only works when pushing to the main branch as its main purpose is to publish it as a snapshot to maven central. If we want to restrict merges to only check-passing ones, we need to run the checks also for the PRs. This is now implemented in the test.yml, which runs on all branches |
Weltraumschaf
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we prevent merging of branches with failing tests into main