Skip to content

Commit 281d53f

Browse files
committed
#36 Decompose method to make code testable
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
1 parent cabc1c5 commit 281d53f

File tree

2 files changed

+13
-1
lines changed
  • src
    • main/java/io/securecodebox/persistence/defectdojo/http
    • test/java/io/securecodebox/persistence/defectdojo/http

2 files changed

+13
-1
lines changed

src/main/java/io/securecodebox/persistence/defectdojo/http/Foo.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public RestTemplate createRestTemplate() {
6969

7070
final var builder = HttpClientBuilder.create();
7171
builder.useSystemProperties();
72-
builder.setProxy(new HttpHost(proxyConfig.getHost(), proxyConfig.getPort()));
72+
builder.setProxy(createHttpHost());
7373
builder.setDefaultCredentialsProvider(credentials);
7474
builder.setProxyAuthenticationStrategy(new ProxyAuthenticationStrategy());
7575

@@ -88,4 +88,8 @@ AuthScope createAuthScope() {
8888
Credentials createCredentials() {
8989
return new UsernamePasswordCredentials(proxyConfig.getUser(), proxyConfig.getPassword());
9090
}
91+
92+
HttpHost createHttpHost() {
93+
return new HttpHost(proxyConfig.getHost(), proxyConfig.getPort());
94+
}
9195
}

src/test/java/io/securecodebox/persistence/defectdojo/http/FooTest.java

+8
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,14 @@ void createCredentials() {
8484
assertAll(
8585
() -> assertThat(result.getUserPrincipal().getName(), is(proxyConfig.getUser())),
8686
() -> assertThat(result.getPassword(), is(proxyConfig.getPassword()))
87+
88+
@Test
89+
void createHttpHost() {
90+
final var result = sut.createHttpHost();
91+
92+
assertAll(
93+
() -> assertThat(result.getHostName(), is(proxyConfig.getHost())),
94+
() -> assertThat(result.getPort(), is(proxyConfig.getPort()))
8795
);
8896
}
8997
}

0 commit comments

Comments
 (0)