Skip to content

Commit cabc1c5

Browse files
committed
#36 Decompose method to make code testable
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
1 parent 887d8b7 commit cabc1c5

File tree

2 files changed

+17
-1
lines changed
  • src
    • main/java/io/securecodebox/persistence/defectdojo/http
    • test/java/io/securecodebox/persistence/defectdojo/http

2 files changed

+17
-1
lines changed

src/main/java/io/securecodebox/persistence/defectdojo/http/Foo.java

+6-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import lombok.NonNull;
99
import org.apache.http.HttpHost;
1010
import org.apache.http.auth.AuthScope;
11+
import org.apache.http.auth.Credentials;
1112
import org.apache.http.auth.UsernamePasswordCredentials;
1213
import org.apache.http.client.CredentialsProvider;
1314
import org.apache.http.impl.client.BasicCredentialsProvider;
@@ -63,7 +64,7 @@ public RestTemplate createRestTemplate() {
6364
final var credentials = new BasicCredentialsProvider();
6465
credentials.setCredentials(
6566
createAuthScope(),
66-
new UsernamePasswordCredentials(proxyConfig.getUser(), proxyConfig.getPassword())
67+
createCredentials()
6768
);
6869

6970
final var builder = HttpClientBuilder.create();
@@ -83,4 +84,8 @@ public RestTemplate createRestTemplate() {
8384
AuthScope createAuthScope() {
8485
return new AuthScope(proxyConfig.getHost(), proxyConfig.getPort());
8586
}
87+
88+
Credentials createCredentials() {
89+
return new UsernamePasswordCredentials(proxyConfig.getUser(), proxyConfig.getPassword());
90+
}
8691
}

src/test/java/io/securecodebox/persistence/defectdojo/http/FooTest.java

+11
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import io.securecodebox.persistence.defectdojo.config.Config;
88
import lombok.NonNull;
99
import org.apache.http.auth.AuthScope;
10+
import org.apache.http.auth.Credentials;
1011
import org.junit.jupiter.api.Disabled;
1112
import org.junit.jupiter.api.Test;
1213
import org.springframework.http.HttpHeaders;
@@ -75,4 +76,14 @@ void createAuthScope() {
7576
() -> assertThat(result.getPort(), is(proxyConfig.getPort()))
7677
);
7778
}
79+
80+
@Test
81+
void createCredentials() {
82+
final var result = sut.createCredentials();
83+
84+
assertAll(
85+
() -> assertThat(result.getUserPrincipal().getName(), is(proxyConfig.getUser())),
86+
() -> assertThat(result.getPassword(), is(proxyConfig.getPassword()))
87+
);
88+
}
7889
}

0 commit comments

Comments
 (0)