Class declaration line is marked as uncovered in PHPUnit 9.3

[emodric]

Q	A
PHPUnit version	9.3-dev
PHP version	7.4
Installation Method	Composer

Summary

For some classes, PHPUnit marks the class declaration line (final class Foo) as uncovered.

Current behavior

How to reproduce

Not really sure how to reproduce aside from upgrading from PHPUnit 9.2 to 9.3 and migrating coverage config.

Expected behavior

To behave as PHPUnit 9.2

[sebastianbergmann]

@dvdoug Could this be related to your refactorings / improvements?

[dvdoug]

@emodric, which coverage driver are you using? And what value do you have for processUncoveredFiles? If the answers are "Xdebug" and "true" then I think this is https://bugs.xdebug.org/view.php?id=1798

[emodric]

I use Xdebug 2.9.6 and I do not have processUncoveredFiles configured (I don't know the default value).

Note that I only upgraded phpunit/phpunit from 9.2 to 9.3 and with it phpunit/php-code-coverage from 8.0.2 to dev-master. Is this something that manifests only on dev-master of phpunit/php-code-coverage (due to Xdebug issue you linked)?

[dvdoug]

@emodric would you mind deleting var/cache and try running your test suite again? I'm curious if that will act as a workaround for you (theory being that the Symfony container will be recompiled which involves require on the classes before coverage is turned on)

The linked Xdebug bug has been there a while I think, but released versions of php-code-coverage seem to accidentally work around it

[emodric]

I'm not running this in Symfony context (i.e. no Symfony app, no var/cache/, no container). This is a pure unit tests run, no integration testing.

[emodric]

To make it clearer, I'm aware that screenshots show that I'm using Symfony controllers in my tests, that indeed is a run in Symfony context.

BUT, this also happens in a separate run not related to Symfony. I only happened to pick a first class I ran into, which was a Symfony controller :)

I will try deleting the cache to see if it least fixes it there.

[emodric]

@dvdoug Clearing Symfony cache for integration tests definitely helped. But as I said in my other comment, this happens in a separate run not related to Symfony, so there's no Symfony cache to clear.

[dvdoug]

@emodric Thanks for confirming. "Manually clear the Symfony cache before every test run" is obviously a terrible workaround, but that does confirm the Xdebug issue affects extends as well as implements.

@sebastianbergmann The issue is that the class declaration is (sometimes) initially marked as an executable line by Xdebug, but then each test run only returns lines inside methods as actually executed. I'll see what I can do on the php-code-coverage side to mitigate.

[mvorisek]

related with https://bugs.xdebug.org/view.php?id=1798