Skip to content

Make navbar sticky #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sinharaksh1t
Copy link
Contributor

@sinharaksh1t sinharaksh1t commented Sep 18, 2024

Resolves #331

Demo (GIF) for Before vs. After:

Before

leetcode patterns before

After

leetcode patterns after

Copy link
Owner

@seanprashad seanprashad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you opening a PR for this @sinharaksh1t! Everything looks good to me 👍🏽

@seanprashad seanprashad merged commit ce00350 into seanprashad:main Sep 19, 2024
@sinharaksh1t
Copy link
Contributor Author

Thank you for the quick merge, @seanprashad!

I'm curious what is the CI/CD pipeline like? Do the changes in main branch get auto deployed or do you do it manually?

@seanprashad
Copy link
Owner

They currently don't get autodeployed via the github-pages GitHub Action - this is something I should definitely look into because I remember it was working previously.

I've just manually kicked off a deployment - you should see the changes reflected in ~10 minutes or so!

@sinharaksh1t
Copy link
Contributor Author

Wonderful, thanks a lot! :D

@sinharaksh1t sinharaksh1t deleted the sinharaksh1t/make-navbar-sticky branch January 13, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep Navigation bar stuck to the top even while scrolling
2 participants