Skip to content

Fixed randomQuestions - now it uses filtered questions #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

idsulik
Copy link
Contributor

@idsulik idsulik commented Dec 2, 2023

When you filter rows using different filters and click on "Try a random question" it picks depending on all/checked/unchecked filter, but now it picks only within the rows the user see right now, so it considers all filters

Copy link
Owner

@seanprashad seanprashad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on this @idsulik!

@seanprashad seanprashad merged commit 8b82a26 into seanprashad:main Dec 2, 2023
@idsulik
Copy link
Contributor Author

idsulik commented Dec 3, 2023

@seanprashad thank you for the great tool!
p.s. could you please deploy this changes?

@seanprashad
Copy link
Owner

This should be deployed now @idsulik - sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants