Skip to content

Fixed faulty link of the Backspace String Compare question #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

gssakash
Copy link
Contributor

I've noticed that the link to discuss for the Backspace String Compare question seems to be wrong and I've fixed it.
Please let me know if I can make any more changes or if I've done something wrong. Thanks!

@seanprashad
Copy link
Owner

Hey @gssakash! Thanks for opening this patch!

The trailing forward slash, ie. /, technically doesn't matter as most browsers will treat them the same (see Google's To slash or not to slash blog post).

There's a handful of other question URLs that are don't have the trailing slash as well - which is totally fine for our case! Please let me know if you have any questions 😀

@fawazhussain
Copy link

Hey, @seanprashad, without the '/' at the end of the URL, solution button leads to an incorrect URL, so i think it is necessary to add the '/' at the end. Thanks!

@seanprashad seanprashad reopened this Dec 3, 2021
@seanprashad
Copy link
Owner

Ah ok! The current URL looks to be malformed:

https://leetcode.com/problems/backspace-string-comparediscuss/?currentPage=1&orderBy=most_votes

Note that we should have a forward slash, ie. /, between compare and discuss like so:

https://leetcode.com/problems/backspace-string-compare/discuss/?currentPage=1&orderBy=most_votes

My apologies for misunderstanding this @gssakash and a very big thank you for pointing this out once more @fawazhussain !!

@seanprashad seanprashad merged commit 3c57856 into seanprashad:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants