Fail on yaml lint errors

[Gui13]

Fixes #737

[Gui13]

I don't really know why the build fails, it seems that it fails on all the tests.

I'm not good enough in Ruby to analyze the issue though.

[sds]

Thanks for this PR, @Gui13. Can you fix the syntax error?

[sds]

Note that fail is a keyword in Ruby so this test will always error (see the failing TravisCI run).

You should use the fail_hook keyword here and below.

[Gui13]

Ok, it is done. I admit ruby is not my main language. I took inspiration from the existing code in this matter.

[Gui13]

@sds I have rebased on your current master just in case.

The three failing tests are out of my scope, so I don't know what else to do.

In any case, this is what we use right now in production: it correctly handles error messages from yamllint

[sds]

The test failure is because the way this if/else is written could be simplified.

You can resolve by writing as:

if result.success?
  :pass 
elsif result.stdout.include?("error")
  [:fail, result.stdout]
else
  [:warn, result.stdout]
end

Notice this is "flatter" than what is currently written.

[sds]

Note that there are still CI failures that should be pretty easy to fix. Can you have a look?

lib/overcommit/hook/pre_commit/yaml_lint.rb:12:14: C: Layout/TrailingWhitespace: Trailing whitespace detected.
lib/overcommit/hook/pre_commit/yaml_lint.rb:13:36: C: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

[Gui13]

OK @sds I did it!

[sds]

Thank you for your help!